[SPARK-19809][SQL][TEST][FOLLOWUP] Move the test case to HiveOrcQuerySuite #19960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Dec 13, 2017
| } | ||
| } | ||
|
|
||
| test("SPARK-19809 NullPointerException on zero-size ORC file") { |
Member
There was a problem hiding this comment.
Should we move the test above SPARK-22267 Spark SQL incorrectly reads ORC files when column order is different too? I think basically that's also the same instance.
Member
Author
There was a problem hiding this comment.
Yep. I'll piggy back here, too.
Member
Author
|
Thank you always for review and approval, @HyukjinKwon ! |
|
Test build #84821 has finished for PR 19960 at commit
|
|
Test build #84823 has finished for PR 19960 at commit
|
Member
|
LGTM |
Member
|
Thanks! Merged to master. |
Member
Author
|
Thank you, @HyukjinKwon and @gatorsmile . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As a follow-up of #19948 , this PR moves the test case and adds comments.
How was this patch tested?
Pass the Jenkins.