Skip to content

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Dec 12, 2017

What changes were proposed in this pull request?

#19208 modified sharedParams.scala, but didn't generated by SharedParamsCodeGen.scala. This involves mismatch between them.

How was this patch tested?

Existing test.

@yanboliang
Copy link
Contributor Author

cc @WeichenXu123 @jkbradley

@SparkQA
Copy link

SparkQA commented Dec 13, 2017

Test build #84805 has finished for PR 19958 at commit d677ab1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait HasCollectSubModels extends Params

Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yanboliang
Copy link
Contributor Author

Merged into master, thanks.

@asfgit asfgit closed this in b03af8b Dec 13, 2017
@yanboliang yanboliang deleted the spark-21087 branch December 13, 2017 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants