[SPARK-3010] fix redundant conditional

[scwf]

https://issues.apache.org/jira/browse/SPARK-3010

this pr is to fix redundant conditional in spark, such as
1.
private[spark] def codegenEnabled: Boolean =
if (getConf(CODEGEN_ENABLED, "false") == "true") true else false
2.
x => if (x == 2) true else false
...

[AmplabJenkins]

Can one of the admins verify this patch?

[markhamstra]

If you really want to trim redundancy, the parens are now unnecessary -- as are the braces and the 'x'. So, you could pare this all the way down to:

val prunedRDD2 = PartitionPruningRDD.create(rdd, _ == 2)

[markhamstra]

Something seems to be amiss in this PR: Several of your changes are neither in master already nor are they showing up in Files changed. Mismerged?

And some of your changes don't really go all the way toward cleaning up the logic. For example,

(aclsEnabled() && (user != null) && (!viewAcls.contains(user))) == false

would be better as

!aclsEnabled || user == null || viewAcls.contains(user)

[scwf]

@markhamstra, thanks for comments. I have merged SecurityManager right now and updated with your comments.

[mateiz]

Jenkins, test this please

[mateiz]

Looks good to me pending tests

[SparkQA]

QA tests have started for PR 1992 at commit b2a044a.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 1992 at commit b2a044a.

• This patch fails unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class ExecutorClassLoader(conf: SparkConf, classUri: String, parent: ClassLoader,

[scwf]

@mateiz , retest this please, tests failed due to forked process exit code is not zero.
see #2108

[mateiz]

Jenkins, test this please

[SparkQA]

QA tests have started for PR 1992 at commit b2a044a.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 1992 at commit b2a044a.

• This patch fails unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[scwf]

@mateiz retest this again, tests failed in sparkstreaming, thanks.

[pwendell]

Jenkins, test this please.

[scwf]

hi @pwendell, jenkins fetch error.

[JoshRosen]

Jenkins, retest this please.

[SparkQA]

QA tests have started for PR 1992 at commit b2a044a.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 1992 at commit b2a044a.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mateiz]

Merged this, thanks!