Skip to content

[SPARK-22500][SQL] Fix 64KB JVM bytecode limit problem with cast #19730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[SPARK-22500][SQL] Fix 64KB JVM bytecode limit problem with cast #19730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9013671
initial commit
kiszk Nov 12, 2017
94dfde2
address review comment
kiszk Nov 13, 2017
39ffaa9
make changes smaller
kiszk Nov 13, 2017
83fef40
address review comment
kiszk Nov 17, 2017
c46ef5c
address review comments
kiszk Nov 21, 2017
574691f
address review comment
kiszk Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,13 +1039,21 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String
}
}
"""
}.mkString("\n")
}
val fieldsEvalCodes = if (ctx.INPUT_ROW != null && ctx.currentVars == null) {
Copy link
Contributor

@mgaido91 mgaido91 Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be ctx.currentVars != null?

Copy link
Member Author

@kiszk kiszk Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ctx.currentVars != null, we need to use mkString("\n").

ctx.splitExpressions(
expressions = fieldsEvalCode,
funcName = "castStruct",
arguments = ("InternalRow", tmpRow) :: (rowClass, result) :: Nil)
} else {
fieldsEvalCode.mkString("\n")
}

(c, evPrim, evNull) =>
s"""
final $rowClass $result = new $rowClass(${fieldsCasts.length});
final InternalRow $tmpRow = $c;
$fieldsEvalCode
$fieldsEvalCodes
$evPrim = $result;
"""
}
Expand Down
18 changes: 18 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,4 +827,22 @@ class CastSuite extends SparkFunSuite with ExpressionEvalHelper {

checkEvaluation(cast(Literal.create(input, from), to), input)
}

test("SPARK-22500: cast for struct should not generate codes beyond 64KB") {
val N = 250

val fromInner = new StructType(
(1 to N).map(i => StructField(s"s$i", DoubleType)).toArray)
val toInner = new StructType(
(1 to N).map(i => StructField(s"i$i", IntegerType)).toArray)
val inputInner = Row.fromSeq((1 to N).map(i => i + 0.5))
val outputInner = Row.fromSeq((1 to N))
val fromOuter = new StructType(
(1 to N).map(i => StructField(s"s$i", fromInner)).toArray)
val toOuter = new StructType(
(1 to N).map(i => StructField(s"s$i", toInner)).toArray)
val inputOuter = Row.fromSeq((1 to N).map(_ => inputInner))
val outputOuter = Row.fromSeq((1 to N).map(_ => outputInner))
checkEvaluation(cast(Literal.create(inputOuter, fromOuter), toOuter), outputOuter)
}
}