[SPARK-20396][SQL][PySpark][FOLLOW-UP] groupby().apply() with pandas udf #19517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 122a7bc.
|
Test build #82841 has finished for PR 19517 at commit
|
|
Test build #82842 has finished for PR 19517 at commit
|
ueshin
changed the title
Member
|
retest this please |
gatorsmile
reviewed
Oct 20, 2017
python/pyspark/sql/functions.py
Outdated
|
|
||
|
|
||
| class PythonUdfType(object): | ||
| # row-based UDFs |
Member
There was a problem hiding this comment.
Nit: Please update all row-based UDFs to row-at-a-time UDFs
gatorsmile
reviewed
Oct 20, 2017
| import org.apache.spark.sql.types.DataType | ||
|
|
||
| private[spark] object PythonUdfType { | ||
| // row-based UDFs |
Member
Author
There was a problem hiding this comment.
Sure, I'll update it, too.
Member
|
LGTM. @ueshin Could you remove |
ueshin
changed the title
|
Test build #82922 has finished for PR 19517 at commit
|
|
Test build #82921 has finished for PR 19517 at commit
|
Member
|
retest this please |
|
Test build #82926 has finished for PR 19517 at commit
|
Member
|
retest this please |
|
Test build #82936 has finished for PR 19517 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #18732.
This pr modifies
GroupedData.apply()method to convert pandas udf to grouped udf implicitly.How was this patch tested?
Exisiting tests.