[SPARK-22233] [CORE] [FOLLOW-UP] Allow user to filter out empty split in HadoopRDD #19504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
srowen
approved these changes
Oct 16, 2017
Contributor
|
It looks better. |
|
Test build #82787 has finished for PR 19504 at commit
|
liutang123
reviewed
Oct 16, 2017
| .set(HADOOP_RDD_IGNORE_EMPTY_SPLITS, true) | ||
| sc = new SparkContext(conf) | ||
|
|
||
| def testIgnoreEmptySplits( |
Contributor
There was a problem hiding this comment.
testIgnoreEmptySplits(
data = Array.empty[Tuple2[String, String]],
actualPartitionNum = 1,
expectedPartitionNum = 0)
=>
testIgnoreEmptySplits(
data = Array.empty[(String, String)],
actualPartitionNum = 1,
expectedPartitionNum = 0)
Contributor
|
LGTM, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the config
spark.files.ignoreEmptySplits, rename it and make it internal.This is followup of #19464
How was this patch tested?
Exsiting tests.