Skip to content

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Oct 13, 2017

What changes were proposed in this pull request?

This is a minor folllowup of #19474 .

#19474 partially reverted #18064 but accidentally introduced a behavior change. Command extended LogicalPlan before #18064 , but #19474 made it extend LeafNode. This is an internal behavior change as now all Command subclasses can't define children, and they have to implement computeStatistic method.

This PR fixes this by making Command extend LogicalPlan

How was this patch tested?

N/A

@cloud-fan
Copy link
Contributor Author

cc @gatorsmile

@gatorsmile
Copy link
Member

LGTM pending Jenkins

@SparkQA
Copy link

SparkQA commented Oct 13, 2017

Test build #82739 has finished for PR 19493 at commit 03cd40a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait Command extends LogicalPlan

@gatorsmile
Copy link
Member

Thanks! Merged to master.

@asfgit asfgit closed this in 3823dc8 Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants