[SPARK-22191] [SQL] Add hive serde example with serde properties #19420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // $example off:spark_hive$ | ||
|
|
||
| // Hive serde's are also supported with serde properties. | ||
| String sqlQuery = "CREATE TABLE src_serde(key decimal(38,18), value int) USING hive" |
Member
There was a problem hiding this comment.
Hi, @crlalam.
We use 2-space indentation in general.
FYI, maybe, you can see Scala Coding Style.
Author
There was a problem hiding this comment.
Hi @dongjoon-hyun ,
Thanks for the review and pointing me to the coding style. Fixed coding style issues and updated the pull request. Please take a look.
Contributor
|
Jenkins OK to test |
holdenk
reviewed
Jan 19, 2018
| // $example off:spark_hive$ | ||
|
|
||
| // Hive serde's are also supported with serde properties. | ||
| String sqlQuery = "CREATE TABLE src_serde(key decimal(38,18), value int) USING hive" + |
Contributor
There was a problem hiding this comment.
The indentation here doesn't match the rest of the function.
Contributor
|
I love more examples, but is there a place we plan to put this in the documentation? |
|
Can one of the admins verify this patch? |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added an example for, specifying serde with serde properties for hive tables using OPTIONS.
How was this patch tested?
Verified manually by running examples with run-example.sh. Verified in Scala, java and python.