[SPARK-11034] [LAUNCHER] [MESOS] Launcher: add support for monitoring Mesos apps #19385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
|
Test build #82744 has finished for PR 19385 at commit
|
Contributor
|
This only solves half the problem, right? What about cluster mode? |
Author
|
Thanks @vanzin for looking into this.
Yes, it solves the Mesos/Client mode. For Mesos/Cluster mode, I think the Standalone/Cluster(SPARK-11033) implementaton(or similar way) would handle since both use the same logic at the client side to submit the application. |
vanzin
reviewed
Oct 13, 2017
| super.start() | ||
|
|
||
| if (sc.deployMode == "client") { | ||
| launcherBackend.connect |
Contributor
There was a problem hiding this comment.
add () since this is not a property getter.
vanzin
reviewed
Oct 13, 2017
Contributor
vanzin
left a comment
vanzin
left a comment
There was a problem hiding this comment.
Sounds good. One minor nit though.
|
Test build #82750 has finished for PR 19385 at commit
|
Contributor
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added Launcher support for monitoring Mesos apps in Client mode. SPARK-11033 can handle the support for Mesos/Cluster mode since the Standalone/Cluster and Mesos/Cluster modes use the same code at client side.
How was this patch tested?
I verified it manually by running launcher application, able to launch, stop and kill the mesos applications and also can invoke other launcher API's.