Skip to content

Conversation

@narahari92
Copy link

What changes were proposed in this pull request?

This adds a new feature transformer which will take a javascript function and based on the logic provided in that, derives new features.

How was this patch tested?

There is proper unit test written for this transformer and also it's been testing in local and yarn-client mode.
Please review http://spark.apache.org/contributing.html before opening a pull request.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just implement Transformer. This adds very little

import org.apache.spark.sql.types.StructField
import org.apache.spark.sql.types.StructType

import javax.script.ScriptEngineManager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think introducing Javascript is a non-starter

@srowen srowen mentioned this pull request Sep 26, 2017
@asfgit asfgit closed this in ceaec93 Sep 27, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closes apache#13794
Closes apache#18474
Closes apache#18897
Closes apache#18978
Closes apache#19152
Closes apache#19238
Closes apache#19295
Closes apache#19334
Closes apache#19335
Closes apache#19347
Closes apache#19236
Closes apache#19244
Closes apache#19300
Closes apache#19315
Closes apache#19356
Closes apache#15009
Closes apache#18253

Author: hyukjinkwon <[email protected]>

Closes apache#19348 from HyukjinKwon/stale-prs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants