[DOCS] Fix unreachable links in the document #19195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #81646 has finished for PR 19195 at commit
|
srowen
approved these changes
Sep 11, 2017
HyukjinKwon
approved these changes
Sep 12, 2017
HyukjinKwon
reviewed
Sep 12, 2017
docs/building-spark.md
Outdated
|
|
||
| * it only scans the paths `src/main` and `src/test` (see | ||
| [docs](http://scala-tools.org/mvnsites/maven-scala-plugin/usage_cc.html)), so it will only work | ||
| [docs](http://davidb.github.io/scala-maven-plugin/example_compile.html)), so it will only work |
Member
There was a problem hiding this comment.
@sarutak, what do you think about using http://davidb.github.io/scala-maven-plugin/example_cc.html instead? (I checked it although it looks not a big deal though as they have similar information).
Member
Author
There was a problem hiding this comment.
I confirmed Internet Archive and I found the link you suggested is more proper. I'll modify it soon. Thanks.
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Sep 12, 2017
## What changes were proposed in this pull request? Recently, I found two unreachable links in the document and fixed them. Because of small changes related to the document, I don't file this issue in JIRA but please suggest I should do it if you think it's needed. ## How was this patch tested? Tested manually. Author: Kousuke Saruta <[email protected]> Closes #19195 from sarutak/fix-unreachable-link. (cherry picked from commit 9575582) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.2, and now that I look again here, realize the last tests technically didn't pass. As it's a doc change only that passed before, I can't see it will fail, but iwll keep an eye out. Oops. |
|
Test build #81680 has finished for PR 19195 at commit
|
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
## What changes were proposed in this pull request? Recently, I found two unreachable links in the document and fixed them. Because of small changes related to the document, I don't file this issue in JIRA but please suggest I should do it if you think it's needed. ## How was this patch tested? Tested manually. Author: Kousuke Saruta <[email protected]> Closes apache#19195 from sarutak/fix-unreachable-link. (cherry picked from commit 9575582) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Recently, I found two unreachable links in the document and fixed them.
Because of small changes related to the document, I don't file this issue in JIRA but please suggest I should do it if you think it's needed.
How was this patch tested?
Tested manually.