[SPARK-21936][SQL][2.2] backward compatibility test framework for HiveExternalCatalog #19163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnalCatalog `HiveExternalCatalog` is a semi-public interface. When creating tables, `HiveExternalCatalog` converts the table metadata to hive table format and save into hive metastore. It's very import to guarantee backward compatibility here, i.e., tables created by previous Spark versions should still be readable in newer Spark versions. Previously we find backward compatibility issues manually, which is really easy to miss bugs. This PR introduces a test framework to automatically test `HiveExternalCatalog` backward compatibility, by downloading Spark binaries with different versions, and create tables with these Spark versions, and read these tables with current Spark version. test-only change Author: Wenchen Fan <[email protected]> Closes apache#19148 from cloud-fan/test.
Contributor
Author
|
cc @gatorsmile |
|
Test build #81547 has finished for PR 19163 at commit
|
viirya
reviewed
Sep 8, 2017
|
|
||
| object PROCESS_TABLES extends QueryTest with SQLTestUtils { | ||
| // Tests the latest version of every release line. | ||
| val testingVersions = Seq("2.0.2", "2.1.1", "2.2.0") |
Member
There was a problem hiding this comment.
Since this is a backport to 2.2, do we still need to test backward compatibility on 2.2?
Member
There was a problem hiding this comment.
I thought it's needed against 2.2.0, here.
Member
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Sep 8, 2017
…eExternalCatalog backport #19148 to 2.2 Author: Wenchen Fan <[email protected]> Closes #19163 from cloud-fan/test.
Member
|
Thanks! Merged to 2.2. Could you close this PR? |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…eExternalCatalog backport apache#19148 to 2.2 Author: Wenchen Fan <[email protected]> Closes apache#19163 from cloud-fan/test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #19148 to 2.2