Skip to content

Conversation

@copester
Copy link

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@copester copester changed the title [SPARK-1766] sorted functions to meet pedantic requirements [SPARK-2140] Enabling YARN memory overhead calculation from heap of the JVM Aug 12, 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is always returns args.amMemory.

@mateiz
Copy link
Contributor

mateiz commented Aug 26, 2014

Jenkins, this is ok to test

@SparkQA
Copy link

SparkQA commented Aug 26, 2014

QA tests have started for PR 1906 at commit a2abc51.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 26, 2014

QA tests have finished for PR 1906 at commit a2abc51.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

@copester Any chance you can upmerge this and update based on the jira conversation. I think the issue is actually with yarn alpha version now. The yarn alpha version of this shouldn't subtract out the memoryOverhead since its using that directly as the heap size and adding in the memory overhead when it requests the AM container ( memoryResource.setMemory(args.amMemory + memoryOverhead)).

We also don't really need to do the logic there of rounding based on the getMinimumResourceCapability because Yarn will handle that for us. So I think we can actually remove the calculateAMMemory routines and just use args.amMemory.

@tgravescs
Copy link
Contributor

I assume this is replaced by #2253. Can you close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants