[MINOR]Correct validateAndTransformSchema in GaussianMixture and AFTSurvivalRegression #18980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah I think you're right. There's a similar issue in |
Contributor
|
+1 @srowen, this is a bug. |
Contributor
Author
|
I just fixed AFTSurvivalRegression also. |
srowen
reviewed
Aug 19, 2017
| SchemaUtils.checkColumnType(schema, $(featuresCol), new VectorUDT) | ||
| SchemaUtils.appendColumn(schema, $(predictionCol), IntegerType) | ||
| SchemaUtils.appendColumn(schema, $(probabilityCol), new VectorUDT) | ||
| val schema_temp = SchemaUtils.appendColumn(schema, $(predictionCol), IntegerType) |
Member
There was a problem hiding this comment.
Tiny nit: Java/Scala use camelCase var names. Maybe call this withPredictionCol or something, as it's more descriptive anyway.
Contributor
Author
There was a problem hiding this comment.
My bad! Just committed with more descriptive variables in camelCase. Thanks
Member
|
I started tests. One last request, start the title with |
|
Test build #3892 has finished for PR 18980 at commit
|
sharp-pixel
changed the title
sharp-pixel
changed the title
Member
|
Actually, on second thought, we should make a JIRA for this and link it. It's a non-trivial bug fix. I can do that if you're busy, but feel free to. I'll merge it soon anyway |
Contributor
Author
|
As I am fairly new to JIRA, feel free to do that if you can. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Aug 20, 2017
…SurvivalRegression ## What changes were proposed in this pull request? The line SchemaUtils.appendColumn(schema, $(predictionCol), IntegerType) did not modify the variable schema, hence only the last line had any effect. A temporary variable is used to correctly append the two columns predictionCol and probabilityCol. ## How was this patch tested? Manually. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Cédric Pelvet <[email protected]> Closes #18980 from sharp-pixel/master. (cherry picked from commit 73e04ec) Signed-off-by: Sean Owen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 20, 2017
…SurvivalRegression ## What changes were proposed in this pull request? The line SchemaUtils.appendColumn(schema, $(predictionCol), IntegerType) did not modify the variable schema, hence only the last line had any effect. A temporary variable is used to correctly append the two columns predictionCol and probabilityCol. ## How was this patch tested? Manually. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Cédric Pelvet <[email protected]> Closes #18980 from sharp-pixel/master. (cherry picked from commit 73e04ec) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.2/2.1 |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…SurvivalRegression ## What changes were proposed in this pull request? The line SchemaUtils.appendColumn(schema, $(predictionCol), IntegerType) did not modify the variable schema, hence only the last line had any effect. A temporary variable is used to correctly append the two columns predictionCol and probabilityCol. ## How was this patch tested? Manually. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Cédric Pelvet <[email protected]> Closes apache#18980 from sharp-pixel/master. (cherry picked from commit 73e04ec) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The line SchemaUtils.appendColumn(schema, $(predictionCol), IntegerType) did not modify the variable schema, hence only the last line had any effect. A temporary variable is used to correctly append the two columns predictionCol and probabilityCol.
How was this patch tested?
Manually.
Please review http://spark.apache.org/contributing.html before opening a pull request.