Skip to content

[SPARK-21696][SS] HDFSBackedStateStoreProvider to handle corrupted snapshots #18911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-21696][SS] HDFSBackedStateStoreProvider to handle corrupted snapshots #18911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...n/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,10 @@ private[state] class HDFSBackedStateStoreProvider extends StateStoreProvider wit
} catch {
case _: FileNotFoundException =>
None
case e: IOException =>
logWarning(s"Corrupted snapshot file for version $version of $this: $fileToRead", e)
fs.delete(fileToRead, true)
None
} finally {
if (input != null) input.close()
}
Expand Down
6 changes: 2 additions & 4 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,10 @@ class StateStoreSuite extends StateStoreSuiteBase[HDFSBackedStateStoreProvider]
val snapshotVersion = (0 to 10).find( version =>
fileExists(provider, version, isSnapshot = true)).getOrElse(fail("snapshot file not found"))

// Corrupt snapshot file and verify that it throws error
// Corrupt snapshot file and verify that it doesn't throw an error
assert(getData(provider, snapshotVersion) === Set("a" -> snapshotVersion))
corruptFile(provider, snapshotVersion, isSnapshot = true)
intercept[Exception] {
getData(provider, snapshotVersion)
}
getData(provider, snapshotVersion)

// Corrupt delta file and verify that it throws error
assert(getData(provider, snapshotVersion - 1) === Set("a" -> (snapshotVersion - 1)))
Expand Down