[SPARK-21590][SS]Window start time should support negative values #18903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
ok to test |
brkyvz
reviewed
Aug 11, 2017
| } | ||
| } | ||
|
|
||
| test("SPARK-21590: Start time works with negative values and return microseconds") { |
Contributor
There was a problem hiding this comment.
could you also add a DataFrame test for this with a negative value? then I'll feel a lot more comfortable that we don't have to have the start offset as a positive number in the window calculation.
Look for DataFrameTimeWindowingSuite.scala
Contributor
Author
There was a problem hiding this comment.
Yeah thanks, I added some tests in DataFrameTimeWindowingSuite
Contributor
|
test this please |
Contributor
Author
|
test this please |
|
Test build #4154 has finished for PR 18903 at commit
|
|
Test build #4175 has finished for PR 18903 at commit
|
|
Test build #4178 has finished for PR 18903 at commit
|
Member
|
retest this please |
Member
|
ok to test |
|
Test build #93048 has finished for PR 18903 at commit
|
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the non-negative checks of window start time to make window support negative start time, and add a check to guarantee the absolute value of start time is less than slide duration.
How was this patch tested?
New unit tests.