-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-20963][SQL] Support column aliases for join relations in FROM clause #18772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In |
|
Test build #80047 has finished for PR 18772 at commit
|
|
Jenkins, retest this please. |
|
Test build #80049 has finished for PR 18772 at commit
|
|
ping |
|
ping me? : ) Will review it in the next few days. |
|
oh, yea. Sorry to forget to add |
|
This sounds a good idea to me. 👍 |
|
ok, I'll fix that way. Is it okay to include the fix in this pr? or, follow-up? |
|
Let us do it in a separate PR. Thanks! |
|
ok. When I finished this pr, I'll do. Thanks! |
|
retest this please |
|
LGTM pending Jenkins. |
|
Test build #80290 has finished for PR 18772 at commit
|
|
Thanks! Merging to master. |
|
Thanks! I'll make a pr later to fix this as follow-up. |
… visitTableName ## What changes were proposed in this pull request? This pr (follow-up of #18772) used `UnresolvedSubqueryColumnAliases` for `visitTableName` in `AstBuilder`, which is a new unresolved `LogicalPlan` implemented in #18185. ## How was this patch tested? Existing tests Author: Takeshi Yamamuro <[email protected]> Closes #18857 from maropu/SPARK-20963-FOLLOWUP.
What changes were proposed in this pull request?
This pr added parsing rules to support column aliases for join relations in FROM clause.
This pr is a sub-task of #18079.
How was this patch tested?
Added tests in
AnalysisSuite,PlanParserSuite,andSQLQueryTestSuite.