[SPARK-21306][ML] For branch 2.1, OneVsRest should support setWeightCol #18763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facaiy
changed the title
facaiy
referenced
this pull request
Jul 28, 2017
## What changes were proposed in this pull request? add `setWeightCol` method for OneVsRest. `weightCol` is ignored if classifier doesn't inherit HasWeightCol trait. ## How was this patch tested? + [x] add an unit test. Author: Yan Facai (颜发才) <[email protected]> Closes #18554 from facaiy/BUG/oneVsRest_missing_weightCol. (cherry picked from commit a5a3189) Signed-off-by: Yanbo Liang <[email protected]>
## What changes were proposed in this pull request? add `setWeightCol` method for OneVsRest. `weightCol` is ignored if classifier doesn't inherit HasWeightCol trait. ## How was this patch tested? + [x] add an unit test. Author: Yan Facai (颜发才) <[email protected]> Closes apache#18554 from facaiy/BUG/oneVsRest_missing_weightCol. (cherry picked from commit a5a3189) Signed-off-by: Yanbo Liang <[email protected]>
facaiy
force-pushed
the
BUG/branch-2.1_OneVsRest_support_setWeightCol
branch
from
ddb83da to
571739d
Compare
facaiy
changed the title
facaiy
commented
Jul 28, 2017
|
|
||
| test("SPARK-21306: OneVsRest should support setWeightCol") { | ||
| val dataset2 = dataset.withColumn("weight", lit(1)) | ||
| val dataset2 = dataset.withColumn("weight", lit(1.0)) |
Contributor
Author
There was a problem hiding this comment.
@yanboliang @srowen My mistake. It will be better to use double value 1.0 in master / branch-2.2 / branch-2.3 in the same way.
Contributor
There was a problem hiding this comment.
@facaiy It doesn't matter, since weightCol supports any numeric type and will cast it to double type under the hood.
Contributor
Author
There was a problem hiding this comment.
OK. Could you test and merge the PR into branch 2.1?
Contributor
|
Jenkins, test this please. |
Contributor
|
@srowen Could you help to trigger this job? Thanks. |
|
Test build #3866 has finished for PR 18763 at commit
|
Contributor
|
Jenkins, test this please. |
yanboliang
reviewed
Aug 5, 2017
python/pyspark/ml/classification.py
Outdated
| weightCol = self.getWeightCol() | ||
| else: | ||
| warnings.warn("weightCol is ignored, " | ||
| "as it is not supported by {} now.".format(classifier)) |
Contributor
There was a problem hiding this comment.
To pass Python2.6 test, we need to change this line to:
"as it is not supported by {0} now.".format(classifier))
Contributor
Author
There was a problem hiding this comment.
Modified as suggested, thanks very much!
1 task
Contributor
|
ok to test |
Contributor
|
Jenkins, test this please. |
Member
|
ok to test |
|
Test build #80345 has finished for PR 18763 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 8, 2017
The PR is related to #18554, and is modified for branch 2.1. ## What changes were proposed in this pull request? add `setWeightCol` method for OneVsRest. `weightCol` is ignored if classifier doesn't inherit HasWeightCol trait. ## How was this patch tested? + [x] add an unit test. Author: Yan Facai (颜发才) <[email protected]> Closes #18763 from facaiy/BUG/branch-2.1_OneVsRest_support_setWeightCol.
Contributor
|
Merged into branch-2.1. Thanks @facaiy @gatorsmile |
Contributor
|
It seems github can't close this PR automatically. @facaiy Please feel free to close it manually. Thanks. |
Contributor
Author
|
Thanks, all. |
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
The PR is related to apache#18554, and is modified for branch 2.1. add `setWeightCol` method for OneVsRest. `weightCol` is ignored if classifier doesn't inherit HasWeightCol trait. + [x] add an unit test. Author: Yan Facai (颜发才) <[email protected]> Closes apache#18763 from facaiy/BUG/branch-2.1_OneVsRest_support_setWeightCol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is related to #18554, and is modified for branch 2.1.
What changes were proposed in this pull request?
add
setWeightColmethod for OneVsRest.weightColis ignored if classifier doesn't inherit HasWeightCol trait.How was this patch tested?