Skip to content

Conversation

@JohnHBrock
Copy link

What changes were proposed in this pull request?

  • Change ML LogisticRegression setInitialModel from private to public.
  • Add getInitialModel method.

How was this patch tested?

Running ./dev/run-tests.

@JohnHBrock
Copy link
Author

This contribution is my original work and I license the work to the project under the project’s open source license.

@MLnick
Copy link
Contributor

MLnick commented Jul 25, 2017

Hi there, thanks for this. However, please see #18610 and related JIRA tickets. The solution is slightly more complex and needs to be done in a more generic way. I suggest that this be updated once agreement on #18610 is reached, and makes use of the shared trait in that PR, etc.

Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes pls pending until #18610 is done.

@JohnHBrock
Copy link
Author

#18610 seems to be stuck in purgatory. Is there any option other than waiting for that PR to be resolved? This feels like the perfect being the enemy of the good.

@sethah
Copy link
Contributor

sethah commented Dec 6, 2017

I actually completely agree about perfect being the enemy of good in this case. We should provide something workable that can be safely modified in the future if needed. Still, this needs to be done in the other PR #18610, so I suggest providing feedback and code review on that one until it gets merged, then we can revisit here. Thanks!

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Mar 15, 2020
@github-actions github-actions bot closed this Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants