Turn UpdateBlockInfo into case class. #1872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 1872. This patch merges cleanly. |
Contributor
|
LGTM and wait for Jenkins ... |
|
QA results for PR 1872: |
Contributor
Author
|
I'm going to merge this one into master & branch-1.1 since the test failure is independent of this. |
asfgit
pushed a commit
that referenced
this pull request
Aug 10, 2014
This helps us log UpdateBlockInfo properly once #1870 is merged. Author: Reynold Xin <[email protected]> Closes #1872 from rxin/UpdateBlockInfo and squashes the following commits: 0cee1c2 [Reynold Xin] Turn UpdateBlockInfo into case class. (cherry picked from commit 482c5af) Signed-off-by: Reynold Xin <[email protected]>
Contributor
|
If case class then does it still need to be Externalizable ? |
Contributor
Author
|
It is using some custom serialization to reduce serialization overhead. |
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
This helps us log UpdateBlockInfo properly once apache#1870 is merged. Author: Reynold Xin <[email protected]> Closes apache#1872 from rxin/UpdateBlockInfo and squashes the following commits: 0cee1c2 [Reynold Xin] Turn UpdateBlockInfo into case class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us log UpdateBlockInfo properly once #1870 is merged.