Skip to content

[SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a fetchSize #18515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a fetchSize #18515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,11 @@ class JDBCOptions(
s" and '$JDBC_NUM_PARTITIONS' are required.")
val fetchSize = {
val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt
require(size >= 0,
require(size >= 0 || size == Integer.MIN_VALUE,
Copy link
Member

@gatorsmile gatorsmile Jul 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not make sense to the other data sources except MySQL. If needed, we can introduce a dialect specific checking APIs in JdbcDialect.scala

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for @gatorsmile 's suggestion.

s"Invalid value `${size.toString}` for parameter " +
s"`$JDBC_BATCH_FETCH_SIZE`. The minimum value is 0. When the value is 0, " +
"the JDBC driver ignores the value and does the estimates.")
s"`$JDBC_BATCH_FETCH_SIZE`. The value should be >= 0 or equal Integer.MIN_VALUE. " +
"When the value is 0, the JDBC driver ignores the value and does the estimates. " +
"When the value is Integer.MIN_VALUE then result will be retrieved row-by-row.")
size
}

Expand Down