Skip to content

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Jun 2, 2017

What changes were proposed in this pull request?

This PR reverts PR #16751, #16791, #16817, #16756, and part of #16795 to roll back parquet-mr 1.8.2 to 1.8.1 to escape from a dependency hell caused by avro 1.7.7 and 1.8.1.

How was this patch tested?

Existing tests.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jun 2, 2017

Sorry for this trouble. @liancheng .
Could you revert #16751 , too?
That was the real upgrade to 1.8.2.

@dongjoon-hyun
Copy link
Member

Oh, it's already there in the code. Please just update the PR description.

@viirya
Copy link
Member

viirya commented Jun 2, 2017

@liancheng After upgrading to Parquet 1.8.2, #16756 is another PR merged to remove a workaround for old Parquet issue. We should revert it too if rolling back parquet-mr 1.8.1.

@SparkQA
Copy link

SparkQA commented Jun 2, 2017

Test build #77662 has finished for PR 18181 at commit cf461d0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

@dongjoon-hyun I already reverted PR #16751 manually but forgot to mention it in the PR description.

@liancheng
Copy link
Contributor Author

@viirya Thanks for reminding! I'm reverting that one.

…columns in merged Parquet schema for filter predicate pushdown"

This reverts commit bf49368.
@SparkQA
Copy link

SparkQA commented Jun 2, 2017

Test build #77669 has started for PR 18181 at commit c956201.

@liancheng
Copy link
Contributor Author

liancheng commented Jun 2, 2017

Unfortunately, rolling back parquet-mr to 1.8.1 brings back PARQUET-389, which breaks multiple test cases involving schema evolution (add a new column to a Parquet table and filter on that column).

Trying to figure out a workaround for this but haven't got any luck yet.

cc @marmbrus

@liancheng
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jun 2, 2017

Test build #77673 has finished for PR 18181 at commit c956201.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Also, cc @rdblue and @mallman .

@rdblue
Copy link
Contributor

rdblue commented Jun 2, 2017

-1, with comments on the JIRA issue. I think it is better to include the Parquet fixes in 1.8.2 since Parquet doesn't pull in Avro 1.8.1 - that happens when users declare their own dependency on parquet-avro.

@mallman
Copy link
Contributor

mallman commented Jun 2, 2017

I can't speak to Parquet 1.8.x anymore. We use Parquet 1.9.0 plus a patch for https://issues.apache.org/jira/browse/PARQUET-783 and have had no problems.

@rdblue
Copy link
Contributor

rdblue commented Jun 2, 2017 via email

@liancheng
Copy link
Contributor Author

@rdblue @mallman Thanks for the comments! As mentioned in the JIRA ticket, we've decided to preserve parquet-mr 1.8.2. Instead, we'll add a release notes entry to suggest using parquet-avro 1.8.1 instead of 1.8.2 to avoid the Avro dependency conflict.

I'm closing this PR.

@liancheng liancheng closed this Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants