[SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.StreamingQueryManagerSuite listing #18180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #77661 has finished for PR 18180 at commit
|
Member
|
+1, LGTM. |
Contributor
|
Merging this to master and 2.2 |
asfgit
pushed a commit
that referenced
this pull request
Jun 5, 2017
…rSuite listing ## What changes were proposed in this pull request? When stopping StreamingQuery, StreamExecution will set `streamDeathCause` then notify StreamingQueryManager to remove this query. So it's possible that when `q2.exception.isDefined` returns `true`, StreamingQueryManager's active list still has `q2`. This PR just puts the checks into `eventually` to fix the flaky test. ## How was this patch tested? Jenkins Author: Shixiong Zhu <[email protected]> Closes #18180 from zsxwing/SPARK-20957. (cherry picked from commit bc537e4) Signed-off-by: Tathagata Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When stopping StreamingQuery, StreamExecution will set
streamDeathCausethen notify StreamingQueryManager to remove this query. So it's possible that whenq2.exception.isDefinedreturnstrue, StreamingQueryManager's active list still hasq2.This PR just puts the checks into
eventuallyto fix the flaky test.How was this patch tested?
Jenkins