-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-19236][SQL][FOLLOW-UP] Added createOrReplaceGlobalTempView method #18147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gatorsmile
wants to merge
2
commits into
apache:master
from
gatorsmile:createOrReplaceGlobalTempView
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,39 +35,47 @@ class GlobalTempViewSuite extends QueryTest with SharedSQLContext { | |
| private var globalTempDB: String = _ | ||
|
|
||
| test("basic semantic") { | ||
| sql("CREATE GLOBAL TEMP VIEW src AS SELECT 1, 'a'") | ||
| try { | ||
| sql("CREATE GLOBAL TEMP VIEW src AS SELECT 1, 'a'") | ||
|
|
||
| // If there is no database in table name, we should try local temp view first, if not found, | ||
| // try table/view in current database, which is "default" in this case. So we expect | ||
| // NoSuchTableException here. | ||
| intercept[NoSuchTableException](spark.table("src")) | ||
|
|
||
| // If there is no database in table name, we should try local temp view first, if not found, | ||
| // try table/view in current database, which is "default" in this case. So we expect | ||
| // NoSuchTableException here. | ||
| intercept[NoSuchTableException](spark.table("src")) | ||
| // Use qualified name to refer to the global temp view explicitly. | ||
| checkAnswer(spark.table(s"$globalTempDB.src"), Row(1, "a")) | ||
|
|
||
| // Use qualified name to refer to the global temp view explicitly. | ||
| checkAnswer(spark.table(s"$globalTempDB.src"), Row(1, "a")) | ||
| // Table name without database will never refer to a global temp view. | ||
| intercept[NoSuchTableException](sql("DROP VIEW src")) | ||
|
|
||
| // Table name without database will never refer to a global temp view. | ||
| intercept[NoSuchTableException](sql("DROP VIEW src")) | ||
| sql(s"DROP VIEW $globalTempDB.src") | ||
| // The global temp view should be dropped successfully. | ||
| intercept[NoSuchTableException](spark.table(s"$globalTempDB.src")) | ||
|
|
||
| sql(s"DROP VIEW $globalTempDB.src") | ||
| // The global temp view should be dropped successfully. | ||
| intercept[NoSuchTableException](spark.table(s"$globalTempDB.src")) | ||
| // We can also use Dataset API to create global temp view | ||
| Seq(1 -> "a").toDF("i", "j").createGlobalTempView("src") | ||
| checkAnswer(spark.table(s"$globalTempDB.src"), Row(1, "a")) | ||
|
|
||
| // We can also use Dataset API to create global temp view | ||
| Seq(1 -> "a").toDF("i", "j").createGlobalTempView("src") | ||
| checkAnswer(spark.table(s"$globalTempDB.src"), Row(1, "a")) | ||
| // Use qualified name to rename a global temp view. | ||
| sql(s"ALTER VIEW $globalTempDB.src RENAME TO src2") | ||
| intercept[NoSuchTableException](spark.table(s"$globalTempDB.src")) | ||
| checkAnswer(spark.table(s"$globalTempDB.src2"), Row(1, "a")) | ||
|
|
||
| // Use qualified name to rename a global temp view. | ||
| sql(s"ALTER VIEW $globalTempDB.src RENAME TO src2") | ||
| intercept[NoSuchTableException](spark.table(s"$globalTempDB.src")) | ||
| checkAnswer(spark.table(s"$globalTempDB.src2"), Row(1, "a")) | ||
| // Use qualified name to alter a global temp view. | ||
| sql(s"ALTER VIEW $globalTempDB.src2 AS SELECT 2, 'b'") | ||
| checkAnswer(spark.table(s"$globalTempDB.src2"), Row(2, "b")) | ||
|
|
||
| // Use qualified name to alter a global temp view. | ||
| sql(s"ALTER VIEW $globalTempDB.src2 AS SELECT 2, 'b'") | ||
| checkAnswer(spark.table(s"$globalTempDB.src2"), Row(2, "b")) | ||
| // We can also use Catalog API to drop global temp view | ||
| spark.catalog.dropGlobalTempView("src2") | ||
| intercept[NoSuchTableException](spark.table(s"$globalTempDB.src2")) | ||
|
|
||
| // We can also use Catalog API to drop global temp view | ||
| spark.catalog.dropGlobalTempView("src2") | ||
| intercept[NoSuchTableException](spark.table(s"$globalTempDB.src2")) | ||
| // We can also use Dataset API to replace global temp view | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code added are line 38 and line 73-78 |
||
| Seq(2 -> "b").toDF("i", "j").createOrReplaceGlobalTempView("src") | ||
| checkAnswer(spark.table(s"$globalTempDB.src"), Row(2, "b")) | ||
| } finally { | ||
| spark.catalog.dropGlobalTempView("src") | ||
| } | ||
| } | ||
|
|
||
| test("global temp view is shared among all sessions") { | ||
|
|
@@ -106,7 +114,7 @@ class GlobalTempViewSuite extends QueryTest with SharedSQLContext { | |
| test("CREATE TABLE LIKE should work for global temp view") { | ||
| try { | ||
| sql("CREATE GLOBAL TEMP VIEW src AS SELECT 1 AS a, '2' AS b") | ||
| sql(s"CREATE TABLE cloned LIKE ${globalTempDB}.src") | ||
| sql(s"CREATE TABLE cloned LIKE $globalTempDB.src") | ||
| val tableMeta = spark.sessionState.catalog.getTableMetadata(TableIdentifier("cloned")) | ||
| assert(tableMeta.schema == new StructType().add("a", "int", false).add("b", "string", false)) | ||
| } finally { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we didn't merge the original PR to 2.2 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the backport PR #18167