Skip to content

[Web UI] Remove no need loop in JobProgressListener #18130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Web UI] Remove no need loop in JobProgressListener #18130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e18316
remove no need loop in JobProgressListener
LiShuMing May 27, 2017
d70c5e5
fix new line length > 100
LiShuMing May 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,13 @@ class JobProgressListener(conf: SparkConf) extends SparkListener with Logging {
}
jobIdToData(jobStart.jobId) = jobData
activeJobs(jobStart.jobId) = jobData
for (stageId <- jobStart.stageIds) {
stageIdToActiveJobIds.getOrElseUpdate(stageId, new HashSet[StageId]).add(jobStart.jobId)
}

// If there's no information for a stage, store the StageInfo received from the scheduler
// so that we can display stage descriptions for pending stages:
for (stageInfo <- jobStart.stageInfos) {
stageIdToActiveJobIds.getOrElseUpdate(stageInfo.stageId,
Copy link
Member

@srowen srowen May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not immediately clear to me they're equivalent. They'd have to contain the same set of stage IDs. Is it worth it?

new HashSet[StageId]).add(jobStart.jobId)

stageIdToInfo.getOrElseUpdate(stageInfo.stageId, stageInfo)
stageIdToData.getOrElseUpdate((stageInfo.stageId, stageInfo.attemptId), new StageUIData)
}
Expand Down