[SPARK-20730][SQL] Add an optimizer rule to combine nested Concat #17970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76889 has finished for PR 17970 at commit
|
| SimplifyCreateArrayOps, | ||
| SimplifyCreateMapOps) ++ | ||
| SimplifyCreateMapOps, | ||
| CombineConcat) ++ |
Member
There was a problem hiding this comment.
Hi, @maropu .
CombineConcats like the other Combine~ optimizer?
Member
|
+1, LGTM except one minor naming comment. |
|
Test build #76902 has finished for PR 17970 at commit
|
Member
|
cc @cloud-fan |
viirya
reviewed
May 14, 2017
| import org.apache.spark.sql.types.StringType | ||
|
|
||
|
|
||
| class CombineConcatsSuite extends PlanTest with PredicateHelper { |
Member
There was a problem hiding this comment.
Have we used PredicateHelper here?
Member
|
LGTM except one minor comment. |
|
Test build #76908 has finished for PR 17970 at commit
|
Contributor
|
LGTM, merging to master! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
May 19, 2017
## What changes were proposed in this pull request? This pr added a new Optimizer rule to combine nested Concat. The master supports a pipeline operator '||' to concatenate strings in apache#17711 (This pr is follow-up). Since the parser currently generates nested Concat expressions, the optimizer needs to combine the nested expressions. ## How was this patch tested? Added tests in `CombineConcatSuite` and `SQLQueryTestSuite`. Author: Takeshi Yamamuro <[email protected]> Closes apache#17970 from maropu/SPARK-20730.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? This pr added a new Optimizer rule to combine nested Concat. The master supports a pipeline operator '||' to concatenate strings in apache#17711 (This pr is follow-up). Since the parser currently generates nested Concat expressions, the optimizer needs to combine the nested expressions. ## How was this patch tested? Added tests in `CombineConcatSuite` and `SQLQueryTestSuite`. Author: Takeshi Yamamuro <[email protected]> Closes apache#17970 from maropu/SPARK-20730.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr added a new Optimizer rule to combine nested Concat. The master supports a pipeline operator '||' to concatenate strings in #17711 (This pr is follow-up). Since the parser currently generates nested Concat expressions, the optimizer needs to combine the nested expressions.
How was this patch tested?
Added tests in
CombineConcatSuiteandSQLQueryTestSuite.