[SPARK-20710][SQL] Support aliases in CUBE/ROLLUP/GROUPING SETS #17948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76796 has finished for PR 17948 at commit
|
Member
Author
|
@cloud-fan Could you check this? Thanks! |
cloud-fan
reviewed
May 12, 2017
| */ | ||
| object ResolveAggAliasInGroupBy extends Rule[LogicalPlan] { | ||
|
|
||
| // This is a strict check though, we put this to apply the rule only in alias expressions |
Contributor
There was a problem hiding this comment.
... only if the expression is not resolvable by child
Contributor
|
LGTM |
|
Test build #76848 has started for PR 17948 at commit |
gatorsmile
reviewed
May 12, 2017
| // This is a strict check though, we put this to apply the rule only if the expression is not | ||
| // resolvable by child. | ||
| private def notResolvableByChild(attrName: String, child: LogicalPlan): Boolean = | ||
| !child.output.exists(a => resolver(a.name, attrName)) |
Member
There was a problem hiding this comment.
Nit: style
private def notResolvableByChild(attrName: String, child: LogicalPlan): Boolean = {
!child.output.exists(a => resolver(a.name, attrName))
}
|
Test build #76849 has started for PR 17948 at commit |
Member
|
LGTM too. : ) |
viirya
reviewed
May 12, 2017
|
|
||
| case gs @ GroupingSets(selectedGroups, groups, child, aggs) | ||
| if conf.groupByAliases && child.resolved && aggs.forall(_.resolved) && | ||
| (selectedGroups :+ groups).exists(_.exists(_.isInstanceOf[UnresolvedAttribute])) => |
Member
There was a problem hiding this comment.
groups should cover selectedGroups. So we may not need to add selectedGroups here.
Member
Author
There was a problem hiding this comment.
Aha, I see. It looks reasonable. I'll update. Thanks!
Member
There was a problem hiding this comment.
Are we sure that grouping expressions are all pure attributes? If not, this check might fail.
viirya
reviewed
May 12, 2017
| case gs @ GroupingSets(selectedGroups, groups, child, aggs) | ||
| if conf.groupByAliases && child.resolved && aggs.forall(_.resolved) && | ||
| (selectedGroups :+ groups).exists(_.exists(_.isInstanceOf[UnresolvedAttribute])) => | ||
| def mayResolveAttrByAggregateExprs(exprs: Seq[Expression]): Seq[Expression] = exprs.map { |
Member
There was a problem hiding this comment.
I think we should do exprs.map { _.transform { ... like above.
Member
|
LGTM |
|
Test build #76855 has finished for PR 17948 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 12, 2017
## What changes were proposed in this pull request? This pr added `Analyzer` code for supporting aliases in CUBE/ROLLUP/GROUPING SETS (This is follow-up of #17191). ## How was this patch tested? Added tests in `SQLQueryTestSuite`. Author: Takeshi Yamamuro <[email protected]> Closes #17948 from maropu/SPARK-20710. (cherry picked from commit 92ea7fd) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
|
thanks, merging to master/2.2 |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
May 19, 2017
## What changes were proposed in this pull request? This pr added `Analyzer` code for supporting aliases in CUBE/ROLLUP/GROUPING SETS (This is follow-up of apache#17191). ## How was this patch tested? Added tests in `SQLQueryTestSuite`. Author: Takeshi Yamamuro <[email protected]> Closes apache#17948 from maropu/SPARK-20710.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? This pr added `Analyzer` code for supporting aliases in CUBE/ROLLUP/GROUPING SETS (This is follow-up of apache#17191). ## How was this patch tested? Added tests in `SQLQueryTestSuite`. Author: Takeshi Yamamuro <[email protected]> Closes apache#17948 from maropu/SPARK-20710.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr added
Analyzercode for supporting aliases in CUBE/ROLLUP/GROUPING SETS (This is follow-up of #17191).How was this patch tested?
Added tests in
SQLQueryTestSuite.