[SPARK-20674][SQL] Support registering UserDefinedFunction as named UDF #17915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76642 has started for PR 17915 at commit |
Member
|
retest this please |
kiszk
reviewed
May 9, 2017
| def register( | ||
| name: String, | ||
| udaf: UserDefinedAggregateFunction): UserDefinedAggregateFunction = { | ||
| def register(name: String, udaf: UserDefinedAggregateFunction): UserDefinedAggregateFunction = { |
Member
There was a problem hiding this comment.
nit: Is there any change from the previous one at this line?
Member
There was a problem hiding this comment.
No, I think it's just style change.
|
Test build #76646 has finished for PR 17915 at commit
|
Member
|
LGTM |
Member
|
Thanks! Merging to master/2.2 |
asfgit
pushed a commit
that referenced
this pull request
May 9, 2017
## What changes were proposed in this pull request? For some reason we don't have an API to register UserDefinedFunction as named UDF. It is a no brainer to add one, in addition to the existing register functions we have. ## How was this patch tested? Added a test case in UDFSuite for the new API. Author: Reynold Xin <[email protected]> Closes #17915 from rxin/SPARK-20674. (cherry picked from commit d099f41) Signed-off-by: Xiao Li <[email protected]>
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? For some reason we don't have an API to register UserDefinedFunction as named UDF. It is a no brainer to add one, in addition to the existing register functions we have. ## How was this patch tested? Added a test case in UDFSuite for the new API. Author: Reynold Xin <[email protected]> Closes apache#17915 from rxin/SPARK-20674.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For some reason we don't have an API to register UserDefinedFunction as named UDF. It is a no brainer to add one, in addition to the existing register functions we have.
How was this patch tested?
Added a test case in UDFSuite for the new API.