[SPARK-20635][SQL] No SQL tab in Spark UI #17897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
gatorsmile
reviewed
May 8, 2017
Contributor
Author
There was a problem hiding this comment.
oh, sorry I forgot to delete it...
gatorsmile
reviewed
May 8, 2017
Member
There was a problem hiding this comment.
hiveResultString is for testing only
Contributor
Author
There was a problem hiding this comment.
it's called by SparkSQLDriver.run
Member
There was a problem hiding this comment.
Uh... I did not realize it...
viirya
reviewed
May 8, 2017
| } | ||
| } | ||
|
|
||
| trait InsertTableCommand extends RunnableCommand |
Member
There was a problem hiding this comment.
This might be too broad for this purpose. It could be misunderstood later. Should we add a comment for it?
Contributor
Author
There was a problem hiding this comment.
OK I'll add a comment for it
|
Test build #76567 has finished for PR 17897 at commit
|
Contributor
Author
|
retest this please |
Contributor
|
oh, seems it's included by #17540 ? |
Contributor
Author
|
@cloud-fan OK, let me close this. |
|
Test build #76575 has finished for PR 17897 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There's no SQL tab in Spark UI since
SQLExecution.withNewExecutionIdwas removed fromdef hiveResultStringin this pr. We need to add it back except for insert command, because it starts a new execution throughFileFormatWriter.How was this patch tested?
Test by hand.