[SPARK-20615][ML][TEST] SparseVector.argmax throws IndexOutOfBoundsException #17877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2017 14:01
…ector. This situation can happen when the SparseVector has a size greater than zero but has no defined elements other than zero
srowen
approved these changes
May 5, 2017
|
Test build #3693 has finished for PR 17877 at commit
|
Author
|
Fixed the style issue and ran the Scala style check locally. |
srowen
approved these changes
May 6, 2017
|
Test build #3695 has finished for PR 17877 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 9, 2017
…ception ## What changes were proposed in this pull request? Added a check for for the number of defined values. Previously the argmax function assumed that at least one value was defined if the vector size was greater than zero. ## How was this patch tested? Tests were added to the existing VectorsSuite to cover this case. Author: Jon McLean <[email protected]> Closes #17877 from jonmclean/vectorArgmaxIndexBug. (cherry picked from commit be53a78) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.2/2.1 |
asfgit
pushed a commit
that referenced
this pull request
May 9, 2017
…ception ## What changes were proposed in this pull request? Added a check for for the number of defined values. Previously the argmax function assumed that at least one value was defined if the vector size was greater than zero. ## How was this patch tested? Tests were added to the existing VectorsSuite to cover this case. Author: Jon McLean <[email protected]> Closes #17877 from jonmclean/vectorArgmaxIndexBug. (cherry picked from commit be53a78) Signed-off-by: Sean Owen <[email protected]>
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
…ception ## What changes were proposed in this pull request? Added a check for for the number of defined values. Previously the argmax function assumed that at least one value was defined if the vector size was greater than zero. ## How was this patch tested? Tests were added to the existing VectorsSuite to cover this case. Author: Jon McLean <[email protected]> Closes apache#17877 from jonmclean/vectorArgmaxIndexBug.
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
…ception Added a check for for the number of defined values. Previously the argmax function assumed that at least one value was defined if the vector size was greater than zero. Tests were added to the existing VectorsSuite to cover this case. Author: Jon McLean <[email protected]> Closes apache#17877 from jonmclean/vectorArgmaxIndexBug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a check for for the number of defined values. Previously the argmax function assumed that at least one value was defined if the vector size was greater than zero.
How was this patch tested?
Tests were added to the existing VectorsSuite to cover this case.