[SPARK-20596][ML][TEST] Consolidate and improve ALS recommendAll test cases #17860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76450 has finished for PR 17860 at commit
|
Contributor
Author
Contributor
Author
|
Merged to master/branch-2.2 |
asfgit
pushed a commit
that referenced
this pull request
May 8, 2017
… cases Existing test cases for `recommendForAllX` methods (added in [SPARK-19535](https://issues.apache.org/jira/browse/SPARK-19535)) test `k < num items` and `k = num items`. Technically we should also test that `k > num items` returns the same results as `k = num items`. ## How was this patch tested? Updated existing unit tests. Author: Nick Pentreath <[email protected]> Closes #17860 from MLnick/SPARK-20596-als-rec-tests. (cherry picked from commit 58518d0) Signed-off-by: Nick Pentreath <[email protected]>
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
… cases Existing test cases for `recommendForAllX` methods (added in [SPARK-19535](https://issues.apache.org/jira/browse/SPARK-19535)) test `k < num items` and `k = num items`. Technically we should also test that `k > num items` returns the same results as `k = num items`. ## How was this patch tested? Updated existing unit tests. Author: Nick Pentreath <[email protected]> Closes apache#17860 from MLnick/SPARK-20596-als-rec-tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing test cases for
recommendForAllXmethods (added in SPARK-19535) testk < num itemsandk = num items. Technically we should also test thatk > num itemsreturns the same results ask = num items.How was this patch tested?
Updated existing unit tests.