Skip to content

[MINOR][SQL] Fix the test title from =!= to <=>, remove a duplicated test and add a test for =!= #17842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[MINOR][SQL] Fix the test title from =!= to <=>, remove a duplicated test and add a test for =!= #17842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ class ColumnExpressionSuite extends QueryTest with SharedSQLContext {
StructType(Seq(StructField("a", BooleanType), StructField("b", BooleanType))))
}

private lazy val nullData = Seq(
(Some(1), Some(1)), (Some(1), Some(2)), (Some(1), None), (None, None)).toDF("a", "b")

test("column names with space") {
val df = Seq((1, "a")).toDF("name with space", "name.with.dot")

Expand Down Expand Up @@ -283,23 +286,6 @@ class ColumnExpressionSuite extends QueryTest with SharedSQLContext {
}

test("<=>") {
checkAnswer(
testData2.filter($"a" === 1),
testData2.collect().toSeq.filter(r => r.getInt(0) == 1))

checkAnswer(
testData2.filter($"a" === $"b"),
testData2.collect().toSeq.filter(r => r.getInt(0) == r.getInt(1)))
}

test("=!=") {
val nullData = spark.createDataFrame(sparkContext.parallelize(
Row(1, 1) ::
Row(1, 2) ::
Row(1, null) ::
Row(null, null) :: Nil),
StructType(Seq(StructField("a", IntegerType), StructField("b", IntegerType))))

checkAnswer(
nullData.filter($"b" <=> 1),
Row(1, 1) :: Nil)
Expand All @@ -321,7 +307,18 @@ class ColumnExpressionSuite extends QueryTest with SharedSQLContext {
checkAnswer(
nullData2.filter($"a" <=> null),
Row(null) :: Nil)
}

test("=!=") {
checkAnswer(
nullData.filter($"b" =!= 1),
Row(1, 2) :: Nil)

checkAnswer(nullData.filter($"b" =!= null), Nil)

checkAnswer(
nullData.filter($"a" =!= $"b"),
Row(1, 2) :: Nil)
}

test(">") {
Expand Down