Skip to content

Conversation

@bogdanrdc
Copy link
Contributor

What changes were proposed in this pull request?

SharedSQLContext.afterEach now calls DebugFilesystem.assertNoOpenStreams inside eventually.
SQLTestUtils withTempDir calls waitForTasksToFinish before deleting the directory.

How was this patch tested?

New test but marked as ignored because it takes 30s. Can be unignored for review.

@bogdanrdc
Copy link
Contributor Author

retest this please

@bogdanrdc
Copy link
Contributor Author

Jenkins, retest this please

@hvanhovell
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Apr 21, 2017

Test build #76033 has finished for PR 17720 at commit 6f48fc3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait SharedSQLContext extends SQLTestUtils with BeforeAndAfterEach with Eventually

@SparkQA
Copy link

SparkQA commented Apr 21, 2017

Test build #76035 has finished for PR 17720 at commit 6f48fc3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • trait SharedSQLContext extends SQLTestUtils with BeforeAndAfterEach with Eventually

asfgit pushed a commit that referenced this pull request Apr 22, 2017
…ing ignoreCorruptFiles' flaky test

## What changes were proposed in this pull request?

SharedSQLContext.afterEach now calls DebugFilesystem.assertNoOpenStreams inside eventually.
SQLTestUtils withTempDir calls waitForTasksToFinish before deleting the directory.

## How was this patch tested?
New test but marked as ignored because it takes 30s. Can be unignored for review.

Author: Bogdan Raducanu <[email protected]>

Closes #17720 from bogdanrdc/SPARK-20407-BACKPORT2.1.
@gatorsmile
Copy link
Member

Thanks! Merging to 2.1

Could you close it?

@bogdanrdc bogdanrdc closed this Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants