-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-19851] Add support for EVERY and ANY (SOME) aggregates #17648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Moved this PR to a feature branch and lost comments. The original PR is here: #17194 |
|
Can we just do a logical rewrite to turn them into "condA + condB + condC > 0" (for Some/Any) and "condA + condB + condC = 3" for Every? |
|
@rxin I'm not sure where you're going with your proposal. These are aggregate functions, not scalar functions. |
|
I was saying rather than implementing them, just rewrite them into an aggregate on the conditions and compare them against the value. |
|
@rxin Ok. So you're proposing rewrites for these aggregates that look something like this? |
|
@rxin Actually, @hvanhovell proposed the following rewrites which I think are better: |
|
sgtm |
|
@ptkool Could you address the comments and we can review it? Thanks! |
97bec05 to
e0b5cc6
Compare
|
ok to test |
|
@ptkool mind updating the PR please? |
|
Test build #93044 has finished for PR 17648 at commit
|
|
@dilipbiswal Could you take this over? |
|
@gatorsmile Sure. |
|
@ptkool Thanks for your contribution! This feature will be available in the next release. Spark 3.0 |
What changes were proposed in this pull request?
This pull request implements the EVERY and ANY aggregates.
How was this patch tested?
Testing was performed using unit tests, integration tests, and manual tests.