[SPARK-20344][Scheduler] Duplicate call in FairSchedulableBuilder.addTaskSetManager #17647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
requested changes
Apr 16, 2017
| s"when that file doesn't contain $poolName. Created $poolName with default " + | ||
| s"configuration (schedulingMode: $DEFAULT_SCHEDULING_MODE, " + | ||
| s"minShare: $DEFAULT_MINIMUM_SHARE, weight: $DEFAULT_WEIGHT)") | ||
| var poolName = if (properties != null) { |
| DEFAULT_POOL_NAME | ||
| } | ||
| var parentPool = rootPool.getSchedulableByName(poolName) | ||
| if (parentPool == null && properties != null) { |
Member
There was a problem hiding this comment.
No need to check properties for null?
srowen
approved these changes
Apr 17, 2017
|
Test build #3663 has finished for PR 17647 at commit
|
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…TaskSetManager ## What changes were proposed in this pull request? Eliminate the duplicate call to `Pool.getSchedulableByName()` in `FairSchedulableBuilder.addTaskSetManager` ## How was this patch tested? ./dev/run-tests Author: Robert Stupp <[email protected]> Closes apache#17647 from snazy/20344-dup-call-master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Eliminate the duplicate call to
Pool.getSchedulableByName()inFairSchedulableBuilder.addTaskSetManagerHow was this patch tested?
./dev/run-tests