Skip to content

[SPARK-20315] [SQL] Set ScalaUDF's deterministic to true #17626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-20315] [SQL] Set ScalaUDF's deterministic to true #17626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39abf22
fix.
gatorsmile Apr 13, 2017
4e59b67
correct it
gatorsmile Apr 13, 2017
03303a9
revert
gatorsmile Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ case class ScalaUDF(
udfName: Option[String] = None)
extends Expression with ImplicitCastInputTypes with NonSQLExpression {

// the user-defined functions must be deterministic.
final override def deterministic: Boolean = true
Copy link
Member

@dongjoon-hyun dongjoon-hyun Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, although we decided that this must be true, but should we override this explicitly? Is this for allowing further optimizations like predicate pushdown?


override def nullable: Boolean = true

override def toString: String =
Expand Down