[POC] Remove support for waiting for executors in standalone mode. #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code waits until some minimum fraction of expected executors have registered before beginning scheduling. The current code in standalone mode suffers from a race condition (SPARK-2635). This race condition could be fixed, but this functionality is easily achieved by the user (they can use the storage status to determine how many executors are up, as described by @pwendell in apache#1462) so adding the extra complexity to the scheduler code is not worthwile.
Contributor
Author
There was a problem hiding this comment.
Realized I should fix this to only print the log message once -- will fix this if we decide to use this PR
kayousterhout
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code waits until some minimum fraction of expected executors
have registered before beginning scheduling. The current code in
standalone mode suffers from a race condition (SPARK-2635). This
race condition could be fixed, but this functionality is easily
achieved by the user (they can use the storage status to determine
how many executors are up, as described by @pwendell in #1462)
so adding the extra complexity to the scheduler code may not be worthwhile.
This commit removes the functionality in standalone mode but not for
YARN -- where it is more necessary and the number of expected executors
is well-defined.
This PR is a POC; if the powers-that-be determine that this is what we should
do, I will file a JIRA.
This should be backported into 1.1 if committed.