[SPARK-20303][SQL] Rename createTempFunction to registerFunction #17615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #75725 has started for PR 17615 at commit |
gatorsmile
commented
Apr 12, 2017
| // } else { | ||
| // // This function is a Hive builtin function. | ||
| // ... | ||
| // } |
Member
Author
There was a problem hiding this comment.
LookupFunction already accepts FunctionIdentifier, but we are unable to do it using the above way because functionExists does not consider the difference among Hive built-in, Spark temporary and permanent functions. More following clean-ups are needed. Will try to do it.
gatorsmile
commented
Apr 12, 2017
| * This performs reflection to decide what type of [[Expression]] to return in the builder. | ||
| */ | ||
| def makeFunctionBuilder(name: String, functionClassName: String): FunctionBuilder = { | ||
| protected def makeFunctionBuilder(name: String, functionClassName: String): FunctionBuilder = { |
Member
Author
There was a problem hiding this comment.
registerFunction is the only caller of makeFunctionBuilder after this PR.
gatorsmile
commented
Apr 12, 2017
| // For a permanent, we will store the metadata into underlying external catalog. | ||
| // This function will be loaded into the FunctionRegistry when a query uses it. | ||
| // We do not load it into FunctionRegistry right now. | ||
| // TODO: should we also parse "IF NOT EXISTS"? |
Member
Author
There was a problem hiding this comment.
Should we support it? @cloud-fan @yhuai @rxin
Contributor
|
LGTM |
Member
Author
|
retest this please |
|
Test build #75735 has finished for PR 17615 at commit
|
Member
Author
|
Thanks! Merging to master. |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
### What changes were proposed in this pull request? Session catalog API `createTempFunction` is being used by Hive build-in functions, persistent functions, and temporary functions. Thus, the name is confusing. This PR is to rename it by `registerFunction`. Also we can move construction of `FunctionBuilder` and `ExpressionInfo` into the new `registerFunction`, instead of duplicating the logics everywhere. In the next PRs, the remaining Function-related APIs also need cleanups. ### How was this patch tested? Existing test cases. Author: Xiao Li <[email protected]> Closes apache#17615 from gatorsmile/cleanupCreateTempFunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Session catalog API
createTempFunctionis being used by Hive build-in functions, persistent functions, and temporary functions. Thus, the name is confusing. This PR is to rename it byregisterFunction. Also we can move construction ofFunctionBuilderandExpressionInfointo the newregisterFunction, instead of duplicating the logics everywhere.In the next PRs, the remaining Function-related APIs also need cleanups.
How was this patch tested?
Existing test cases.