[SPARK-20302][SQL] Short circuit cast when from and to types are structurally the same #17614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Apr 12, 2017
| (from, to) match { | ||
| case (left: ArrayType, right: ArrayType) => | ||
| equalsStructurally(left.elementType, right.elementType) && | ||
| left.containsNull == right.containsNull |
Contributor
There was a problem hiding this comment.
shall we be more flexible here? i.e. !left.containsNull || right.containsNull
Contributor
Author
There was a problem hiding this comment.
That's not symmetric. equalsStructurally should be symmetric, unless we rename this something else (e.g. structurallyCastable)
|
Test build #75724 has finished for PR 17614 at commit
|
Contributor
Author
|
Merging in master. |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…cturally the same ## What changes were proposed in this pull request? When we perform a cast expression and the from and to types are structurally the same (having the same structure but different field names), we should be able to skip the actual cast. ## How was this patch tested? Added unit tests for the newly introduced functions. Author: Reynold Xin <[email protected]> Closes apache#17614 from rxin/SPARK-20302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When we perform a cast expression and the from and to types are structurally the same (having the same structure but different field names), we should be able to skip the actual cast.
How was this patch tested?
Added unit tests for the newly introduced functions.