[SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams thread race #17592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Apr 10, 2017
| private val openStreams = mutable.Map.empty[FSDataInputStream, Throwable] | ||
|
|
||
| def clearOpenStreams(): Unit = { | ||
| def addOpenStream(stream: FSDataInputStream): Unit = synchronized { |
Member
There was a problem hiding this comment.
It's a little safer and tidier to synchronize on openStream rather than the containing object. Looks good to me though.
Contributor
|
LGTM |
|
Test build #75661 has finished for PR 17592 at commit
|
|
Test build #75662 has finished for PR 17592 at commit
|
Contributor
|
Merging to master. Thanks! |
Contributor
|
Should this go into branch-2.1 as well? |
asfgit
pushed a commit
that referenced
this pull request
Apr 14, 2017
## What changes were proposed in this pull request? Synchronize access to openStreams map. ## How was this patch tested? Existing tests. Author: Bogdan Raducanu <[email protected]> Closes #17592 from bogdanrdc/SPARK-20243.
Contributor
|
I cherry picked this into branch-2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Synchronize access to openStreams map.
How was this patch tested?
Existing tests.