Skip to content

Conversation

@joyyoj
Copy link
Contributor

@joyyoj joyyoj commented Aug 3, 2014

re-submit

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbstractRpcClient already implements RpcClient - so you don't really need to implement RpcClient.

@SparkQA
Copy link

SparkQA commented Sep 5, 2014

Can one of the admins verify this patch?

@tdas
Copy link
Contributor

tdas commented Oct 21, 2014

Hey @joyyoj

This is a very cool functionality! In fact, we had added a subset of this functionality (sink) as part Spark 1.1, thus validating your approach. However, while this approach provides more functionality, it does at the cost of maintaining this, debugging this, and the cost of addition dependencies like to the spark project, like zookeeper, etc.

We are seeing a lot of such big contributions from the community, which is very encouraging and useful, but will be very hard to maintain for us. So we are trying to figure out a way by which the community can contribute such custom functionality, and maintain it themselves. Say something like a contribs repo...

I will let you know when we have figured something out. Till then please bear with us. :)

@tdas
Copy link
Contributor

tdas commented Dec 24, 2014

@joyyoj
We have set up http://spark-packages.org a way for the community to contribute features and maintain it themselves. Please consider adding your this Flume functionality to http://spark-packages.org/ and let the community use it.

Regarding this PR, mind closing it?

@tdas
Copy link
Contributor

tdas commented Dec 30, 2014

@joyyoj Mind closing this?

@joyyoj
Copy link
Contributor Author

joyyoj commented Dec 31, 2014

Never mind, very very sorry for replay so late.

@joyyoj joyyoj closed this Dec 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants