[SPARK-20218][Doc]'/applications/[app-id]/stages' in REST API,add description. #17534
Conversation
|
Why didn't you add this to your last PR? What other related changes do you want to make? Making several small closely related PRs is frowned on |
…remove redundant description.
|
Because I just use this API today to develop, only to find the problem. |
|
Added one more 2.'/applications/[app-id]/stages/[stage-id]' in REST API,remove redundant description ‘?status=[active|complete|pending|failed] list only stages in the state.’. |
| <td><code>/applications/[app-id]/stages/[stage-id]</code></td> | ||
| <td> | ||
| A list of all attempts for the given stage. | ||
| <br><code>?status=[active|complete|pending|failed]</code> list only stages in the state. |
There was a problem hiding this comment.
Is it filtering stages? or attempts? I am not familiar with this but it wasn't obvious that this is redundant. Maybe you have tried this API locally and confirm this doesn't have effect?
There was a problem hiding this comment.
It is filtering stages.
I have manual test this API locally and confirm this doesn't have effect.
|
Test build #3644 has finished for PR 17534 at commit
|
guoxiaolongzte
changed the title
…ription.
## What changes were proposed in this pull request?
1. '/applications/[app-id]/stages' in rest api.status should add description '?status=[active|complete|pending|failed] list only stages in the state.'
Now the lack of this description, resulting in the use of this api do not know the use of the status through the brush stage list.
2.'/applications/[app-id]/stages/[stage-id]' in REST API,remove redundant description ‘?status=[active|complete|pending|failed] list only stages in the state.’.
Because only one stage is determined based on stage-id.
code:
GET
def stageList(QueryParam("status") statuses: JList[StageStatus]): Seq[StageData] = {
val listener = ui.jobProgressListener
val stageAndStatus = AllStagesResource.stagesAndStatus(ui)
val adjStatuses = {
if (statuses.isEmpty()) {
Arrays.asList(StageStatus.values(): _*)
} else {
statuses
}
};
## How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: 郭小龙 10207633 <[email protected]>
Closes #17534 from guoxiaolongzte/SPARK-20218.
(cherry picked from commit 9e0893b)
Signed-off-by: Sean Owen <[email protected]>
|
Merged to master/2.1 |
3 participants
What changes were proposed in this pull request?
Now the lack of this description, resulting in the use of this api do not know the use of the status through the brush stage list.
2.'/applications/[app-id]/stages/[stage-id]' in REST API,remove redundant description ‘?status=[active|complete|pending|failed] list only stages in the state.’.
Because only one stage is determined based on stage-id.
code:
@get
def stageList(@QueryParam("status") statuses: JList[StageStatus]): Seq[StageData] = {
val listener = ui.jobProgressListener
val stageAndStatus = AllStagesResource.stagesAndStatus(ui)
val adjStatuses = {
if (statuses.isEmpty()) {
Arrays.asList(StageStatus.values(): _*)
} else {
statuses
}
};
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.