Skip to content

Conversation

@liancheng
Copy link
Contributor

JIRA issue: SPARK-2814

@SparkQA
Copy link

SparkQA commented Aug 3, 2014

QA tests have started for PR 1753. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17814/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 3, 2014

QA results for PR 1753:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17814/consoleFull

@marmbrus
Copy link
Contributor

marmbrus commented Aug 3, 2014

This failed only streaming tests (cc @tdas ) I'm going to merge into master and 1.1.

Thanks for fixing this!

@asfgit asfgit closed this in ac33cbb Aug 3, 2014
asfgit pushed a commit that referenced this pull request Aug 3, 2014
…commands

JIRA issue: [SPARK-2814](https://issues.apache.org/jira/browse/SPARK-2814)

Author: Cheng Lian <[email protected]>

Closes #1753 from liancheng/spark-2814 and squashes the following commits:

c74a3b2 [Cheng Lian] Fixed SPARK-2814

(cherry picked from commit ac33cbb)
Signed-off-by: Michael Armbrust <[email protected]>
@chenghao-intel
Copy link
Contributor

Thanks @liancheng , I didn't realize the change will cause NPE. I thought the previous implementation may be more helpful when creating a sub class of HiveContext and override the sessionState as necessary.

Anyway, thank you for reverting this.

@liancheng
Copy link
Contributor Author

@chenghao-intel Didn't realize this when reviewing the PR either :) The dependency is too tricky to follow, and really should be removed. But let's leave it as is for now.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
…commands

JIRA issue: [SPARK-2814](https://issues.apache.org/jira/browse/SPARK-2814)

Author: Cheng Lian <[email protected]>

Closes apache#1753 from liancheng/spark-2814 and squashes the following commits:

c74a3b2 [Cheng Lian] Fixed SPARK-2814
@liancheng liancheng deleted the spark-2814 branch September 24, 2014 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants