Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Apr 4, 2017

What changes were proposed in this pull request?

It seems cran check scripts corrects R/pkg/DESCRIPTION and follows the order in Collate fields.

This PR proposes to fix catalog.R's order so that running this script does not show up a small diff in this file every time.

How was this patch tested?

Manually via ./R/check-cran.sh.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Apr 4, 2017

@felixcheung, maybe it is not worth being as a separate PR. I am fine if you add this in any of your PR that is going to be merged soon. I just opened this as I just found while playing with SparkR locally.

@SparkQA
Copy link

SparkQA commented Apr 4, 2017

Test build #75509 has finished for PR 17528 at commit 6403514.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

that's fine I'm at a lost at how it decides the order? The first part is completely unsorted, right?

     'schema.R'
     'generics.R'
     'jobj.R'
     'column.R'
     'group.R'
     'RDD.R'
      'pairRDD.R'
      'DataFrame.R'
      'SQLContext.R'
      'WindowSpec.R'
      'backend.R'

@felixcheung
Copy link
Member

merged to master.

@asfgit asfgit closed this in 0e2ee82 Apr 4, 2017
@HyukjinKwon
Copy link
Member Author

I just found some references about the order. It seems there was a question about it - http://stackoverflow.com/questions/18544006/how-do-i-indicate-collate-order-in-roxygen2 and https://cran.r-project.org/web/packages/roxygen2/roxygen2.pdf

I didn't run a lot of tests as fortunately It sounds deterministic at least.

@HyukjinKwon HyukjinKwon deleted the minor-reorder-description branch January 2, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants