[SPARK-19235] [SQL] [TEST] [FOLLOW-UP] Enable Test Cases in DDLSuite with Hive Metastore #17524
Conversation
|
Test build #75500 has started for PR 17524 at commit |
|
Test build #75501 has started for PR 17524 at commit |
|
Test build #75502 has started for PR 17524 at commit |
|
retest this please |
|
Test build #75523 has finished for PR 17524 at commit
|
|
retest this please |
|
ok to test |
|
Test build #75727 has started for PR 17524 at commit |
|
retest this please |
|
ok to test |
|
Test build #75841 has finished for PR 17524 at commit
|
|
Test build #76320 has finished for PR 17524 at commit
|
| // the new table path will be removed after DROP TABLE. | ||
| assert(!dir.exists()) | ||
| } finally { | ||
| Utils.deleteRecursively(new File(defaultTablePath)) |
There was a problem hiding this comment.
We need to explicitly drop the original table location.
|
|
||
| test("drop table - data source table") { | ||
| testDropTable(isDatasourceTable = true) | ||
| } |
There was a problem hiding this comment.
Both Hive and SQL packages support data source tables.
|
|
||
| test("drop table") { | ||
| testDropTable(isDatasourceTable = false) | ||
| } |
There was a problem hiding this comment.
Only Hive package supports Hive-serde tables
|
cc @cloud-fan |
|
LGTM, merging to master/2.2 |
…h Hive Metastore ### What changes were proposed in this pull request? This is a follow-up of enabling test cases in DDLSuite with Hive Metastore. It consists of the following remaining tasks: - Run all the `alter table` and `drop table` DDL tests against data source tables when using Hive metastore. - Do not run any `alter table` and `drop table` DDL test against Hive serde tables when using InMemoryCatalog. - Reenable `alter table: set serde partition` and `alter table: set serde` tests for Hive serde tables. ### How was this patch tested? N/A Author: Xiao Li <[email protected]> Closes #17524 from gatorsmile/cleanupDDLSuite. (cherry picked from commit b1e639a) Signed-off-by: Wenchen Fan <[email protected]>
3 participants
What changes were proposed in this pull request?
This is a follow-up of enabling test cases in DDLSuite with Hive Metastore. It consists of the following remaining tasks:
alter tableanddrop tableDDL tests against data source tables when using Hive metastore.alter tableanddrop tableDDL test against Hive serde tables when using InMemoryCatalog.alter table: set serde partitionandalter table: set serdetests for Hive serde tables.How was this patch tested?
N/A