Skip to content

[Spark-20145] Fix range case insensitive bug in SQL #17487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[Spark-20145] Fix range case insensitive bug in SQL #17487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3d2a3ba
add failing test
samelamin Mar 30, 2017
ee15dc0
SPARK-20145: lower case value passed into map to make the statement c…
samelamin Mar 30, 2017
407bdbf
use sql conf to get case sensitivity
samelamin Apr 1, 2017
ccbfcb3
pass failing test
samelamin Apr 2, 2017
e1541b4
pass failing test (reverted from commit ccbfcb32c1e5ccf83c3aea473e309…
samelamin Apr 2, 2017
de7b8a6
use sql conf to get case sensitivity (reverted from commit 407bdbf1ae…
samelamin Apr 2, 2017
8bce1da
revert based on comments from pr
samelamin Apr 2, 2017
ad5780a
code cleanup
samelamin Apr 2, 2017
6efb254
remove empty spaces
samelamin Apr 2, 2017
a01aba6
remove vars and use actual SQL
selamin Apr 3, 2017
406eba8
remove unused test
selamin Apr 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...t/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@

package org.apache.spark.sql.catalyst.analysis

import org.apache.spark.{SparkConf, SparkContext}
import org.apache.spark.sql.catalyst.expressions.Expression
import org.apache.spark.sql.catalyst.plans._
import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, Range}
import org.apache.spark.sql.catalyst.rules._
import org.apache.spark.sql.types.{DataType, IntegerType, LongType}
Expand Down Expand Up @@ -105,7 +103,7 @@ object ResolveTableValuedFunctions extends Rule[LogicalPlan] {

override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
case u: UnresolvedTableValuedFunction if u.functionArgs.forall(_.resolved) =>
builtinFunctions.get(u.functionName) match {
builtinFunctions.get(u.functionName.toLowerCase()) match {
case Some(tvf) =>
val resolved = tvf.flatMap { case (argList, resolver) =>
argList.implicitCast(u.functionArgs) match {
Expand Down
6 changes: 6 additions & 0 deletions sql/core/src/test/resources/sql-tests/inputs/table-valued-functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,9 @@ select * from range(1, 1, 1, 1, 1);

-- range call with null
select * from range(1, null);

-- range call with a mixed-case function name
select * from RaNgE(2);

-- Explain
EXPLAIN select * from RaNgE(2);
20 changes: 19 additions & 1 deletion sql/core/src/test/resources/sql-tests/results/table-valued-functions.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
-- Automatically generated by SQLQueryTestSuite
-- Number of queries: 7
-- Number of queries: 9


-- !query 0
Expand Down Expand Up @@ -85,3 +85,21 @@ struct<>
-- !query 6 output
java.lang.IllegalArgumentException
Invalid arguments for resolved function: 1, null


-- !query 7
select * from RaNgE(2)
-- !query 7 schema
struct<id:bigint>
-- !query 7 output
0
1


-- !query 8
EXPLAIN select * from RaNgE(2)
-- !query 8 schema
struct<plan:string>
-- !query 8 output
== Physical Plan ==
*Range (0, 2, step=1, splits=None)