[SPARK-2454] Do not ship spark home to Workers #1734
Conversation
|
QA tests have started for PR 1734. This patch merges cleanly. |
There was a problem hiding this comment.
is this needed to make the tests work?
There was a problem hiding this comment.
Yeah, otherwise all tests with local-cluster fail
|
QA results for PR 1734: |
|
QA tests have started for PR 1734. This patch merges cleanly. |
|
LGTM pending tests... thanks @andrewor14! |
|
QA results for PR 1734: |
|
Thanks _ merged this |
`spark.test.home` was introduced in #1734. This is fine for SBT but is failing maven tests. Either way it shouldn't throw an NPE. Author: Andrew Or <[email protected]> Closes #1739 from andrewor14/fix-spark-test-home and squashes the following commits: ce2624c [Andrew Or] Do not throw NPE if spark.test.home is not set
`spark.test.home` was introduced in #1734. This is fine for SBT but is failing maven tests. Either way it shouldn't throw an NPE. Author: Andrew Or <[email protected]> Closes #1739 from andrewor14/fix-spark-test-home and squashes the following commits: ce2624c [Andrew Or] Do not throw NPE if spark.test.home is not set
When standalone Workers launch executors, they inherit the Spark home set by the driver. This means if the worker machines do not share the same directory structure as the driver node, the Workers will attempt to run scripts (e.g. bin/compute-classpath.sh) that do not exist locally and fail. This is a common scenario if the driver is launched from outside of the cluster. The solution is to simply not pass the driver's Spark home to the Workers. This PR further makes an attempt to avoid overloading the usages of `spark.home`, which is now only used for setting executor Spark home on Mesos and in python. This is based on top of apache#1392 and originally reported by YanTangZhai. Tested on standalone cluster. Author: Andrew Or <[email protected]> Closes apache#1734 from andrewor14/spark-home-reprise and squashes the following commits: f71f391 [Andrew Or] Revert changes in python 1c2532c [Andrew Or] Merge branch 'master' of github.com:apache/spark into spark-home-reprise 188fc5d [Andrew Or] Avoid using spark.home where possible 09272b7 [Andrew Or] Always use Worker's working directory as spark home
`spark.test.home` was introduced in apache#1734. This is fine for SBT but is failing maven tests. Either way it shouldn't throw an NPE. Author: Andrew Or <[email protected]> Closes apache#1739 from andrewor14/fix-spark-test-home and squashes the following commits: ce2624c [Andrew Or] Do not throw NPE if spark.test.home is not set
…1734) Co-authored-by: Russell Spitzer <[email protected]>
3 participants
When standalone Workers launch executors, they inherit the Spark home set by the driver. This means if the worker machines do not share the same directory structure as the driver node, the Workers will attempt to run scripts (e.g. bin/compute-classpath.sh) that do not exist locally and fail. This is a common scenario if the driver is launched from outside of the cluster.
The solution is to simply not pass the driver's Spark home to the Workers. This PR further makes an attempt to avoid overloading the usages of
spark.home, which is now only used for setting executor Spark home on Mesos and in python.This is based on top of #1392 and originally reported by @YanTangZhai. Tested on standalone cluster.