Skip to content

[SPARK-19970][SQL] Table owner should be USER instead of PRINCIPAL in kerberized clusters #17311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[SPARK-19970][SQL] Table owner should be USER instead of PRINCIPAL in kerberized clusters #17311

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dfbf82
[SPARK-19970][SQL] Table owner should be USER instead of PRINCIPAL in…
dongjoon-hyun Mar 16, 2017
e8ef7d1
Replace `getUserFromAuthenticator` because it is introduced in 0.13.
dongjoon-hyun Mar 16, 2017
2959d98
Change styles.
dongjoon-hyun Mar 17, 2017
5efdf8b
`conf` is not used.
dongjoon-hyun Mar 17, 2017
258ff8d
Revert "`conf` is not used."
dongjoon-hyun Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ private[hive] object HiveClientImpl {
hiveTable.setFields(schema.asJava)
}
hiveTable.setPartCols(partCols.asJava)
conf.foreach(c => hiveTable.setOwner(c.getUser))
conf.foreach { _ => hiveTable.setOwner(SessionState.get().getAuthenticator().getUserName()) }
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think we can remove conf here.

Copy link
Contributor

@vanzin vanzin Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, you're not using it anymore. So away it goes.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Mar 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzin . Some test cases seems to related with conf is None, it causes failures. In this PR, I'll focus on putting the correct name only with the exactly same situations of the previous existing logic.

Copy link
Member

@gatorsmile gatorsmile Mar 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pass the user name.

Copy link
Contributor

@vanzin vanzin Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you be using the state field in the class instead of SessionState.get()? Maybe that will allow you to get rid of the foreach.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state is in class HiveClientImpl, but this function is in object HiveClientImpl.

Copy link
Contributor

@vanzin vanzin Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh. Now it makes sense why conf would be None.

hiveTable.setCreateTime((table.createTime / 1000).toInt)
hiveTable.setLastAccessTime((table.lastAccessTime / 1000).toInt)
table.storage.locationUri.map(CatalogUtils.URIToString(_)).foreach { loc =>
Expand Down