[SPARK-19869][SQL]move table related ddl from ddl.scala to tables.scala #17211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #74209 has finished for PR 17211 at commit
|
Contributor
Author
|
cc @cloud-fan |
|
Test build #74210 has finished for PR 17211 at commit
|
gatorsmile
reviewed
Mar 12, 2017
| AttributeReference("database_description_item", StringType, nullable = false)() :: | ||
| AttributeReference("database_description_value", StringType, nullable = false)() :: Nil | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The remaining commands are database only. We can move the database related commands to org.apache.spark.sql.execution.command.databases.scala.
Contributor
Author
There was a problem hiding this comment.
ok~ thanks, another problem is now the lines of tables.scala is 1594, this is too large, should we need to split it to reduce the lines of a file?
Member
|
This change might cause people hard to track the change history. Maybe we can close this PR? |
Member
|
We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
move table related ddl from ddl.scala to tables.scala
How was this patch tested?
N/A