[SPARK-19775][SQL] Remove an obsolete partitionBy().insertInto() test case

[dongjoon-hyun]

What changes were proposed in this pull request?

This issue removes a test case which was introduced by SPARK-14459 and was superseded by SPARK-16033. Basically, we cannot use partitionBy and insertInto together.

  test("Reject partitioning that does not match table") {
    withSQLConf(("hive.exec.dynamic.partition.mode", "nonstrict")) {
      sql("CREATE TABLE partitioned (id bigint, data string) PARTITIONED BY (part string)")
      val data = (1 to 10).map(i => (i, s"data-$i", if ((i % 2) == 0) "even" else "odd"))
          .toDF("id", "data", "part")

      intercept[AnalysisException] {
        // cannot partition by 2 fields when there is only one in the table definition
        data.write.partitionBy("part", "data").insertInto("partitioned")
      }
    }
  }

How was this patch tested?

This only removes a test case. Pass the existing Jenkins test.

[srowen]

Ideally @rdblue can confirm

[dongjoon-hyun]

Right, thank you, @srowen .

[rdblue]

+1

Looks fine to me. partitionBy support with insertInto was removed. This is probably still passing because it expects an analysis exception that is thrown for a different reason. We should update assertions like this to verify the error message to avoid that in the future.

[dongjoon-hyun]

Thank you for the review, @rdblue !

[SparkQA]

Test build #73618 has finished for PR 17106 at commit 6276818.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Merged to master

[dongjoon-hyun]

Thank you for merging, @srowen .